Repository navigation
Bugfix yaml parsing for GKEStartKueueInsideClusterOperator - #39234
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
area:system-tests
provider:cncf-kubernetes
moiseenkov
force-pushed
the
start_kueue_fix_yaml_parsing
branch
4 times, most recently
from
April 26, 2024 14:59
fb279e3 to
cf5a92f
Compare
Contributor
moiseenkov
force-pushed
the
start_kueue_fix_yaml_parsing
branch
3 times, most recently
from
May 6, 2024 10:49
13a0256 to
86d37d1
Compare
Contributor
|
can we have unit test to avoid regression? |
moiseenkov
force-pushed
the
start_kueue_fix_yaml_parsing
branch
from
May 7, 2024 06:59
91b8e56 to
cc21e4e
Compare
Contributor
Author
Sure, I added tests. Please, take a look. |
moiseenkov
force-pushed
the
start_kueue_fix_yaml_parsing
branch
from
May 7, 2024 09:25
cc21e4e to
28b3fde
Compare
moiseenkov
force-pushed
the
start_kueue_fix_yaml_parsing
branch
from
May 7, 2024 12:14
28b3fde to
29ef8ca
Compare
potiuk
approved these changes
May 7, 2024
eladkal
approved these changes
May 7, 2024
24 of 66 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix yaml parsing for
GKEStartKueueInsideClusterOperator